42School / norminette

Official 42 norminette
MIT License
956 stars 140 forks source link

Struct comments #434

Closed oktorok closed 11 months ago

oktorok commented 1 year ago

Hi, on the pdf says:

III.9 Comments
• Comments cannot be inside functions’ bodies. Comments must be at the end of a line, or on their own line
• Your comments must be in English. And they must be useful.
• A comment cannot justify the creation of a carryall or bad function.

Are comments inside of struct bodies allowed?

Ex:

typedef struct s_thingy {
double min_x;
double max_x;
// Maximum value on the x axis.
double min_y;
// Minimum value on the y axis.
double max_y;
// Maximum value on the y axis.
} t_thingy;

If it is allowed, the script should be fixed because does not allow it, if its the opposite should be added to the pdf.

In case its the second option i can do a merge request with the changes to the pdf if you want.

Thank you so much

matthieu42Network commented 1 year ago

Hello, I'd say it should be allowed

Miniature commented 1 year ago

this bug also applies to enums and unions