search

42atomys / mc-advancements-reloaded

Enhance your Minecraft advancements experience with a revamped UI that utilizes more of your screen space, especially at higher GUI scales. This mod is a continuation of the original AdvancementInfo mod by gbl marked as end-of-life since Jun 2024.
https://modrinth.com/mod/advancements-reloaded
MIT License
8 stars 1 forks source link

Color display behavior in description of advancement is different from vanilla #11

Closed ItzSkyReed closed 3 months ago

ItzSkyReed commented 4 months ago

in vanilla, if the exact color of the advancement is not specified in the description of the advancement, then the color is inherited from the frame of advancement, but in the description of the criteria, when pressed, it remains gray (screenshot 1), which should not be, as it seems to me, and the color should match the color of the advancement description (screenshot 2). frame color is dark_purple (#AA00AA) for challenges and green (#55FF55) for task/goal

Screenshot1 image

Screenshot2 image

42atomys commented 4 months ago

Hi, the goal is to allow full customization for developers with a future API. The idea for the future is to set specific colors for achievement names and to create an icon or badge, I don't reach this step actually ^^

The bug I noticed is that the gray color on a light background significantly reduces the readability of the description.

ItzSkyReed commented 3 months ago

The bug I noticed is that the gray color on a light background significantly reduces the readability of the description.

I didn't mean that exactly, I meant more that if the color of the advancement description is not specified, then it would be better to make it the same as the color of the name of this advancement, and not gray.

42atomys commented 3 months ago

Oh ok, thanks for the clarification I miss it, that a good idea yes

42atomys commented 3 months ago

Hi again, the issue are resolved in v0.4.1, available on modrinth right now https://modrinth.com/mod/advancements-reloaded

See you soon !

ItzSkyReed commented 3 months ago

Thanks!