42atomys / stud42

Stud42 official repository since major 3 update (https://s42.app)
https://s42.app
MIT License
859 stars 27 forks source link

chore: migrate clusters map for paris campus to noc42 #462

Closed sungyongcho closed 1 year ago

sungyongcho commented 1 year ago

Describe the pull request

This pull request involves the migration of the clusters map for the Paris campus to noc42. The reason for this migration is due to construction work at 42 Paris, where the old building no longer exists, and has been replaced by noc42. This task ensures that the clusters map accurately represents the current state of the campus, providing an up-to-date resource for users. By completing this migration, we maintain the accuracy and relevance of our campus information, ensuring a smooth transition to the new noc42 setting.

Checklist

Additional context

Hello, paris cluster map upating pull request is here, but there are couple of things needs to be clarified, and needs modification

  1. for creating a new Cluster object, it gives error when ideitifier is set to 'bess-f1' or 'paul-f1', even after updating extractorRegexp to below

    extractorRegexp = (): RegExp =>
    /(?<clusterWithLetter>(e|bess-f)(?<cluster>\d+))(?<rowWithLetter>r(?<row>\d+))(?<workspaceWithLetter>p(?<workspace>\d+))/i;

    the error arise from clusterMap.tsx file, and needs an investigations.

  2. For bess-f1, the 'P' blocks are for personal computer space.

  3. For Paul clusters, i went to the clusters, and it was physically separated room, and don't have a connection. My opinion is, since the two clusters are separated, it would be better to display them separately, but that's just my opinion.

I've made the codes for bess-f1,2,3 and paul-f3, and turned them into the comments, because of the 1. giving out an error.

close #461

42atomys commented 1 year ago

Hey,thanks for your inputs and context, i will check this out tomorrow with my morning coffee ☕

Thanks again for your contribution for Paris campus !

sungyongcho commented 1 year ago

Hello, for now all the cluster maps are added! I've applied 'PW', the personal worplace, to bess-F1, for now. and I have a suggestion, that some of the cluster has meeting rooms, which are placed inside the cluster area (yes the new building feels new) that students can freely use. I wonder if I can use 'PW' for those areas, or maybe another notion(icon) is needed for it..?

(If this is not appropriate for PR, please let me know!!)

42atomys commented 1 year ago

@sungyongcho I don't have this information as well, we can release this map without meeting room and see in another PR to add a solution for meeting room, WDYT ?

sungyongcho commented 1 year ago

hello @42atomys, I totally agree with your idea, and will bring you some photos next week! I'm not sure how to get inputs from the active user of the service tho...

42atomys commented 1 year ago

I'm not sure how to get inputs from the active user of the service tho... I don't have tool to do that, maybe I send a survey on discord if some active users answer to the poll

Maybe think about an "experiment" architecture to toggle (like feature flag) some part of the app in the future can be awesome ans useful.

Note: I run the formatter for you, I will merge it 🎉

Release v0.26 will be done tomorrow with morning coffee, including this changes ☕