search

42atomys / stud42

Stud42 official repository since major 3 update (https://s42.app)
https://s42.app
MIT License
859 stars 27 forks source link

Add Tokyo campus #464

Closed masakiva closed 1 year ago

masakiva commented 1 year ago

Describe the pull request

Added the Tokyo campus information following the tutorial on https://github.com/42atomys/stud42/wiki/Contributions

Checklist

I didn't manage to open the application in my Browser to see the changes (localhost:3000 keeps loading without displaying anything) Also, I'm sorry, I don't know how to run the linter...

link to the issue #347

42atomys commented 1 year ago

Hello @masakiva,

Thanks for your first contribution 🎉 your follow is great, for your problem on run the project, the installation is explain step by step on : https://github.com/42Atomys/stud42/blob/main/CONTRIBUTING.md ?

FYI: Formating the interface can be run under vscode tasks : >Run Tasks >Format interface or with yarn make-pretty. But actually your work pass the linter and test so no formatting is needed, congratulations 🎉

The last step I need to handle before merge is to valid with a staff member of 42 Tokyo (this is for data protection and data process law in France).

masakiva commented 1 year ago

@42atomys Thank you for your kind reply, and for the explanations. I asked the staff, I will come back when I will get a response!

masakiva commented 1 year ago

The staff is OK for merging, I gave them your email adress (contact@atomys.fr), you should receive an email soon!

masakiva commented 1 year ago

@42atomys Thank you for the small fix, and for the merge! I look forward to using the new version with my campusmates soon!!