search

42coders / eu-cookie-consent

MIT License
60 stars 17 forks source link

multilanguage_support not working for getUpdatePopup() #12

Closed leonnicklas closed 1 year ago

leonnicklas commented 1 year ago

I just saw the cool new feature where later updating the users settings were implemented. Very Nice feature!

BUT: I just found out that the multilanguage_support feature isn't working when trying to update the settings. Instead of showing all cookies in the current app_locale it just shows them in the default app_locale set in config/app.php! If the cookie banner however isn't set at all and the popup shows for the first time everything works just fine.

Does anyone have an idea on how to solve this problem? I couldn't find a solution yet.

leonnicklas commented 1 year ago

@42coders do you have any suggestions?

Max-Hutschenreiter commented 1 year ago

I will lock into both issues today thanks for the reporting

Max-Hutschenreiter commented 1 year ago

Fixed in the v1.0.5 release thanks for letting me know about the bug.

leonnicklas commented 1 year ago

Thx for the new release BUT sadly the multilanguage_support still isn't working for me on update_popup(). Any idea why it isn't working correctly. I couldn't find a way to get it to work. Hope you could help me out:)

Max-Hutschenreiter commented 1 year ago

How do you set the language? The popup HTML is received via an ajax call. Before was a bug inside that the language was not handled correctly in this ajax call. But I added it, and now it's working fine for me. The package uses the default Laravel __('') multilanguage function.

leonnicklas commented 1 year ago

I'm using the default Laravel multilanguage function but it's still not working for me:/ I'm also using a custom setLocale middleware as priority middleware to set the app language to the users preference... Maybe that has something to do with it...