Looks like a nice package. I was reviewing the code, I noticed you allow prefixing the table names. The migrations only use the prefix on the up() method. When calling down via a rollback, you could end up dropping a different table. Kind of a critical issue.
{
/**
* Run the migrations.
*
* @return void
*/
public function up()
{
Schema::create(config('workflows.db_prefix').'workflows', function (Blueprint $table) {
$table->id();
$table->string('name');
$table->timestamps();
});
}
/**
* Reverse the migrations.
*
* @return void
*/
public function down()
{
Schema::dropIfExists('workflows');
}
}
Looks like a nice package. I was reviewing the code, I noticed you allow prefixing the table names. The migrations only use the prefix on the up() method. When calling down via a rollback, you could end up dropping a different table. Kind of a critical issue.