42dx / edgio-go-sdk

Go SDK implementing Edgio's REST API
http://github.42dx.dev/edgio-go-sdk/
MIT License
8 stars 1 forks source link

[REFACTOR]: Change `GetHTTPJSONResult` function to return data #40

Closed rafapaulin closed 6 months ago

rafapaulin commented 6 months ago

Description

Currently, GetHTTPJSONResult modifies a var reference to "return" the data retrieved from the HTTP call. This behavior is not ideal, and may lead to poor maintenance/unexpected behavior in the future. Not to mention that it kills the idiomatic go concept.

Proposed Solution

As a developer, I want to be able to use the GetHTTPJSONResult util in a more predictable/idiomatic way, so that it is more clear/maintainable to use it throughout the other packages

Alternatives / Workarounds

The util is currently working, but it is a bad practice. It could be kept as is, but it is not ideal.

Acceptance Criteria

Additional Context

N/A

References

N/A

Code of Conduct

Upvote & Fund

Fund with Polar

42dx-bot[bot] commented 5 months ago

:tada: This issue has been resolved in version 1.0.0-beta.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: