enable mattermost login via irc PASS command during handshake instead of PRIVMSG

42wim / matterircd

Connect to your mattermost or slack using your IRC-client of choice.

MIT License

295 stars 60 forks source link

Closed dgruss closed 6 years ago

dgruss commented 6 years ago

this allows to just pass the mattermost credentials as the server password in the irc client

42wim commented 6 years ago

Thanks for the PR! Some small issues:

you've modified vendored files, could you please make your PR against upstream: https://github.com/42wim/mm-go-irckit ? (I know it's annoying, am planning to add it back to matterircd instead of stand-alone lib)
matterircd supports slack aswel as mattermost, so the PASS should work for both. Maybe detect if the pass is a slack token, or an extra argument to specify mattermost or slack