fix NAMES reply to send entire member list

42wim / matterircd

Connect to your mattermost or slack using your IRC-client of choice.

MIT License

295 stars 60 forks source link

Closed uchwings closed 6 years ago

uchwings commented 6 years ago

also fixes NAMES command to parse multiple comma-separated channels as specified in https://tools.ietf.org/html/rfc2812#section-3.2.5 (but does not handle the no-argument, list-all-channels form)

42wim commented 6 years ago

Thanks for the patch, but this is in vendored code, could you open your PR at https://github.com/42wim/mm-go-irckit instead ?

Thanks!

uchwings commented 6 years ago

Oops. I'll try to get around to it tomorrow.

Is there a reason to commit copies of dependencies instead of using git submodules?

42wim commented 6 years ago

go get doesn't support submodules, but even if it did, I like to vendor it in case upstream is gone.

uchwings commented 6 years ago

I've made a PR to the other repository.