search

42wim / matterircd

Connect to your mattermost or slack using your IRC-client of choice.
MIT License
295 stars 60 forks source link

Own messages not reflected on the bridge when sent from mattermost #195

Closed Ppjet6 closed 5 years ago

Ppjet6 commented 6 years ago

Steps to reproduce

What happens

My own messages are not reflected on the bridge. I only get the other participant's messages.

What I expect

See all messages that are sent in the discussion.

42wim commented 6 years ago

That's not possible afaik, you can't spoof a private message from yourself in a query with another user. Also annotated in the code: https://github.com/42wim/mm-go-irckit/blob/master/mmuser.go#L334

Ppjet6 commented 6 years ago

On 2018/06/27, Wim wrote:

That's not possible afaik, you can't spoof a private message from yourself in a query with another user. Also annotated in the code: https://github.com/42wim/mm-go-irckit/blob/master/mmuser.go#L334

I am not sure I understand what spoof means in this context, nor the comment in the code. I'm probably missing a bit of context.

-- Maxime “pep” Buquet

42wim commented 5 years ago

See https://tools.ietf.org/html/rfc1459#section-4.4.1 for more information about how private messages to users work.

The only possible workaround for this is using a separate IRC channel for a private message instead of using IRC queries

42wim commented 5 years ago

@Ppjet6 Apparently newer clients do support this kind of spoofing and I've added support for this in master. You need a recent irssi to see it working (I've tested with irssi 1.1.1)

Ppjet6 commented 5 years ago

On 2018/11/03, Wim wrote:

Apparently newer clients do support this kind of spoofing and I've added support for this in master. You need a recent irssi to see it working (I've tested with irssi 1.1.1)

Thanks a lot! I'll give it a go.

-- Maxime “pep” Buquet