-mminsecure flag is always overridden

42wim / matterircd

Connect to your mattermost or slack using your IRC-client of choice.

MIT License

295 stars 60 forks source link

-mminsecure flag is always overridden #200

Closed rmzg closed 5 years ago

rmzg commented 6 years ago

Line 60 from vendor/github.com/42wim/mm-go-irckit/mmuser.go:

 u.MmInfo.Cfg.Insecure = cfg.MattermostSettings.Insecure

Doesn't that always override the Insecure setting configured by the command line flag?

dromer commented 6 years ago

Didn't look at the code, but with latest release using -mminsecure the login with the bot still tries to connect over https

rmzg commented 6 years ago

Yeah, that's what I was experiencing. Changing the line I mentioned fixed it, basically it's always using the 'default' setting from the config file and it overwrites the setting from the command line flag.

42wim commented 5 years ago

Fixed in master