search

42wim / matterircd

Connect to your mattermost or slack using your IRC-client of choice.
MIT License
295 stars 60 forks source link

Cannot join channels #227

Closed repomaa closed 5 years ago

repomaa commented 5 years ago

I'm trying to set up matterircd in a way that it doesn't autojoin any channels so i set JoinInclude = ["&messages"]. It works in a way: no channels except for &messages and &users are created... I can't join any channels after that though. I want to be able to use my irc client's autojoin mechanics and get the rest of the messages to &messages. I just get the invite-only response from the server "Cannot join channel (+i)".

Version: 0.18.4

Necrathex commented 5 years ago

Also after closing the channel in the irc client it's not possible to rejoin it (even though the user is in the mattermost channel).

setpill commented 5 years ago

Also having this problem, and after shuffling around this debug statement (it didn't do any good being called AFTER the error check broke the code flow), I got the following information:

Join channel off-topic, id , err: : Invalid or missing channel_id parameter in request URL, module=matterircd

So the channel isn't actually +i.

setpill commented 5 years ago

The issue turned out to be a missing teamId, caused by trying to /join #off-topic rather than /join #teamname/off-topic. The bug (in our case) seems to be that CmdJoin does not respect the DefaultTeam setting.

setpill commented 5 years ago

@jreinert can you confirm whether adding the team name and a slash before the channel in your join command fixes the problem for you? If so, the above PR should properly resolve this issue.

setpill commented 5 years ago

Recent commits to master have fixed this issue for us.

42wim commented 5 years ago

Should be fixed in master, reopen if still an issue.