search

42wim / matterircd

Connect to your mattermost or slack using your IRC-client of choice.
MIT License
295 stars 60 forks source link

Private message backlog shows as coming from myself #267

Closed kkofler closed 4 years ago

kkofler commented 4 years ago

I am using matterircd v0.19.4 with Mattermost 5.17.3. I have received a private message from another user while I was offline. Upon connecting, matterircd replays the message, but makes it look as if I had sent it myself. (It shows up as coming from my own username and the actual author is not shown anywhere.)

guilhermepiccoli commented 4 years ago

I've noticed a similar behavior: if I'm on matterircd and open a web tab with mattermost, if I send a private message to any user, it shows in IRC as coming from me, no reference to the user targeted.

kkofler commented 4 years ago

That's not exactly the same bug though. In my case, the messages have actually been sent by user X to me and show up as messages from me to me. That is clearly wrong and should be relatively easy to fix.

In your case, the messages have been sent by you to user X, which cannot really be mapped correctly. (I would expect those messages to not be replayed at all.) The only way to get the messages appear in the dialog with user X in your IRC client would be to make them look like messages from user X, which would also be incorrect.

guilhermepiccoli commented 4 years ago

Thanks Kevin, I agree with you. My issue is a bit different and much less important, I just commented here in order to have the clarification, thanks for commenting! BTW, congrats for matterircd! Great piece of software, life saver in a world of RAM eater clients heheh

Cheers,

Guilherme

42wim commented 4 years ago

This should be fixed in master