search

42wim / matterircd

Connect to your mattermost or slack using your IRC-client of choice.
MIT License
294 stars 60 forks source link

add ShortenReplies #322

Closed vmpjdc closed 4 years ago

vmpjdc commented 4 years ago

This makes busy reply threads on long messages more tolerable, in my brief experience.

The length limit is entirely arbitrary and could be made configurable.

Example:

<pjdc> `To build Emacs with xwidgets support, you will need to install
       the webkit2gtk-4.0 package; version 2.12 or later is required. (This
       change was actually made in Emacs 26.1, but was not called out in its
       NEWS.)`
<pjdc> just one more reply test, eh? (re @pjdc: `To build Emacs with ...)
42wim commented 4 years ago

Good idea!

Are you open to change this from a bool to an configurable option, because I'm sure people will want to specify their own length :-)

ReplyLength , ReplySize or ReplyCutoff (or if you have a better idea for a name)

vmpjdc commented 4 years ago

Absolutely!

I'm also going to look at removing newlines: replies to multi-line preformatted pastes are still less than ideal even with the shortening.

vmpjdc commented 4 years ago

I've also made a further change I thought of over the weekend, which is to ignore @foo when counting characters so that there'll still be some context included even if a bunch of people were tagged in the original message.

42wim commented 4 years ago

Thanks!