search

42wim / matterircd

Connect to your mattermost or slack using your IRC-client of choice.
MIT License
294 stars 60 forks source link

Thread support2 #344

Closed hloeung closed 3 years ago

hloeung commented 3 years ago

Per https://github.com/42wim/matterircd/pull/320, split out support for replying to older threads using parent/post ID.

10:59 @@epjhhxi3fpd33kb7usmyfuza6r testing replying to old thread 11:00 @@epjhhxi3fpd33kb7usmyfuza6c testing replying to invalid thread 11:00 @@epjhhxi3fpd33kb7usmyfuza6r 11:00 @@epjhhxi3fpd33kb7usmyfuza6rabc

WEI0lHdNNR

hloeung commented 3 years ago

@42wim, so something like this?

42wim commented 3 years ago

Yes, thank you :)

micah commented 3 years ago

Would this mean I wouldn't need to enable PrefixContext, or SuffixContext to be able to reply to threads?

hloeung commented 3 years ago

Would this mean I wouldn't need to enable PrefixContext, or SuffixContext to be able to reply to threads?

With this change, you can reply to threads with the thread / parent ID (@@.{26}) without the need to enable PrefixContext or SuffixContext. There is no option to show the thread/parent ID though, as that was rejected in https://github.com/42wim/matterircd/pull/320 in favor of PrefixContext/SuffixContext.

micah commented 3 years ago

How would you know what the thread/parent ID would be without the PrefixContext/SuffixContext?

hloeung commented 3 years ago

How would you know what the thread/parent ID would be without the PrefixContext/SuffixContext?

Web UI.

@42wim would you accept a patch enabling showing of thread/parent ID? (e.g. ShowThreadID) So would be similar to https://github.com/42wim/matterircd/pull/320 just renamed config option.

42wim commented 3 years ago

@hloeung what about integrating it in SuffixContext and PrefixContext and adding another option called ThreadContext which only works when one of the former options are enabled.

An empty ThreadContext uses the default context settings, but setting ThreadContext="parentid" will show the parentID instead of the matterircd generated id.

hloeung commented 3 years ago

@hloeung what about integrating it in SuffixContext and PrefixContext and adding another option called ThreadContext which only works when one of the former options are enabled.

An empty ThreadContext uses the default context settings, but setting ThreadContext="parentid" will show the parentID instead of the matterircd generated id.

@42wim, works for me, https://github.com/42wim/matterircd/pull/348