search

42wim / matterircd

Connect to your mattermost or slack using your IRC-client of choice.
MIT License
294 stars 60 forks source link

Do not show replies when hidereplies is enabled (mattermost) #352

Closed 42wim closed 3 years ago

42wim commented 3 years ago

@hloeung this seem to has been changed in fbb3b5e368e2001880a9552d417903c283176577 and seems to have passed by me ;( I was still running an old version in my daily setup until today)

HideReplies shouldn't modify the original message or add nicks. If people want replies or highlights they should enable it. If people really need it there could be an extra option, so those who need it please open an issue.

hloeung commented 3 years ago

@hloeung this seem to has been changed in fbb3b5e and seems to have passed by me ;( I was still running an old version in my daily setup until today)

heh, get with the program!

HideReplies shouldn't modify the original message or add nicks. If people want replies or highlights they should enable it. If people really need it there could be an extra option, so those who need it please open an issue.

It was actually useful previously where it was a middle ground between showing the full reply and being highlighted when someone replied to you. But yeah, with ShortenRepliesTo, this probably makes less sense and can be achieved with ShortenRepliesTo something really small.