42wim / matterircd

Connect to your mattermost or slack using your IRC-client of choice.
MIT License
294 stars 60 forks source link

Fix channel mentions and add option to disable channel mentions as IRC NOTICEs #418

Closed hloeung closed 3 years ago

hloeung commented 3 years ago

Fixes https://github.com/42wim/matterircd/issues/416

We fix it so only if the message contains channel mentions @{here,channel,all} rather than if the parent message:

|21:37 -hloeung:#haw-test- @here Testing again [@@4f7tqoranpgd9bb98itfxt87qw]
|21:37 <hloeung> This time replying, which shouldn't be an IRC NOTICE message but rather PRIVMSG (re @hloeung: @here Testing again) [↪@@4f7tqoranpgd9bb98itfxt87qw]

Also adds an option to allow disabling channel wide mentions. When enabled:

|20:40 <hloeung> @here test [@@18qrfrwa9prk7y9hew49dtahio]

When disabled, which is the current behavior:

|20:41 -hloeung:#haw-test- @here test [@@18qrfrwa9prk7y9hew49dtahio]
42wim commented 3 years ago

👍