Always use stored last viewed at if present

42wim / matterircd

Connect to your mattermost or slack using your IRC-client of choice.

MIT License

294 stars 60 forks source link

Always use stored last viewed at if present #424

Closed hloeung closed 3 years ago

hloeung commented 3 years ago

This partially reverts commit 3a0d0b3ad0557d92f51397e58a7e5ed2fd265a7c. We can't trust that Mattermost has updated the last viewed for channel which is why we store the LastViewedAt internally (see https://github.com/42wim/matterircd/pull/361 and #245).

Apologies @42wim

hloeung commented 3 years ago

Marking it as draft for now. Need to think more about it.

hloeung commented 3 years ago

Right, the issue was not trusting Mattermost updating the server side LastViewedAt so we'll see multiple replays of the same msgs.

Closing this off as it's not an issue then.