Closed hloeung closed 1 year ago
@hloeung can you look at the conflicts below (bridge/mattermost6/mattermost.go)?
@42wim ok removed that block
This is getting a bit too complex though :/
It doesn't seem to work correctly when using prefixcontext A multiline message now shows this for me
21:56 <@wim> [001] this are multiple
21:56 <@wim> [002] lines
21:56 <@wim> [003] with
21:56 <@wim> [004] ```
21:56 <@wim> [005] codeblock
21:56 <@wim> [006]
21:56 <@wim> [007] ```
21:56 <@wim> [008] done
and only replying on @@008
works, no way to see that this is a multiline message.
with hidecontextmulti disabled it gives me this
22:28 <@wim> this are multiple
22:28 <@wim> lines
22:28 <@wim> with
22:28 <@wim> ```
22:28 <@wim> codeblock
22:28 <@wim> ```
22:28 <@wim> [001] done
(replying on @@001
works though)
while what I actually want is
22:28 <@wim> [001] this are multiple
22:28 <@wim> lines
22:28 <@wim> with
22:28 <@wim> ```
22:28 <@wim> codeblock
22:28 <@wim> ```
22:28 <@wim> done
Other comments on the changes:
MsgSpoofUser
and Channel Spoof
, those methods are responsible for writing to irc and should do those checks, it's not guaranteed that in the future only the handleDirectMessageEvent
and handleChannelMessageEvent
are the only ones using those methodsShowContextMulti: false
if showContext
maybe in a separate method as it's the same thing repeated@42wim , okay, try it out now!
I did some testing with all combinations I can think of.
|22:52 <hloeung> Testing
|22:52 <hloeung> [001] Test One
|22:52 <hloeung> [001] Test Two (space above)
|22:52 <hloeung> [001] Test Three
|22:52 <hloeung> [002] Test One
|22:52 <hloeung> Test Two (space above)
|22:52 <hloeung> Test Three
|22:53 <hloeung> [@@3pcmi4un7td5ups4oi7r3txjxe] Test One
|22:53 <hloeung> Test Two (space above)
|22:53 <hloeung> Test Three
|22:53 <hloeung> Test One
|22:53 <hloeung> Test Two (space above)
|22:53 <hloeung> Test Three [@@qowh4sewe7rtdcxzzn8o43mb1e]
|22:53 <hloeung> Test One
|22:53 <hloeung> Test Two (space above)
|22:53 <hloeung> Test Three (re @hloeung: Test One Test Two (space …) [↪@@qowh4sewe7rtdcxzzn8o43mb1e]
|22:54 <hloeung> Test One
|22:54 <hloeung> Test Two (space above)
|22:54 <hloeung> Test Three (re @hloeung: Test One Test Two (space …) [↪@@qowh4sewe7rtdcxzzn8o43mb1e,@@ko7b5wdkwpry78u1ugasb53jzc]
|22:54 <hloeung> Test One [↪@@qowh4sewe7rtdcxzzn8o43mb1e,@@iizy1uftnjnpuxaspq9gdw5wse]
|22:54 <hloeung> Test Two (space above) [↪@@qowh4sewe7rtdcxzzn8o43mb1e,@@iizy1uftnjnpuxaspq9gdw5wse]
|22:54 <hloeung> Test Three (re @hloeung: Test One Test Two (space …) [↪@@qowh4sewe7rtdcxzzn8o43mb1e,@@iizy1uftnjnpuxaspq9gdw5wse]
|22:55 <hloeung> [↪@@qowh4sewe7rtdcxzzn8o43mb1e,@@3g597sjsu7nktbhueaayou1xbo] Test One
|22:55 <hloeung> [↪@@qowh4sewe7rtdcxzzn8o43mb1e,@@3g597sjsu7nktbhueaayou1xbo] Test Two (space above)
|22:55 <hloeung> [↪@@qowh4sewe7rtdcxzzn8o43mb1e,@@3g597sjsu7nktbhueaayou1xbo] Test Three (re @hloeung: Test One Test Two (space …)
|22:55 <hloeung> [@@usxm55ixaintpci43a6eghz6kw] Test One
|22:55 <hloeung> [@@usxm55ixaintpci43a6eghz6kw] Test Two (space above)
|22:55 <hloeung> [@@usxm55ixaintpci43a6eghz6kw] Test Three
Thanks a lot for your work / time on this!
With the new no splitting multi-line messages in PR #482, multi-line messages are displayed as:
Unfortunately, it means using tools such as grepping won't show all the lines as part of the message. This fixes that: