search

42wim / matterircd

Connect to your mattermost or slack using your IRC-client of choice.
MIT License
294 stars 60 forks source link

Fallback to use API for getting channel data when not in the cache #490

Closed hloeung closed 1 year ago

hloeung commented 1 year ago

Fixes https://github.com/42wim/matterircd/issues/479

hloeung commented 1 year ago

Pushed a fix which also fixes this:

ERRO[2022-11-04T09:39:21Z] didn't find channel ggy... (ggy...): channel not found  module=matterircd

Likely due to the same issue where page limit isn't obeyed so not present in the cache. This is not really a fix but more a workaround. Untested, will do more testing tomorrow (it's late here).

hloeung commented 1 year ago

https://github.com/42wim/matterircd/pull/491, I think we should still have this as a fallback, but your call.

42wim commented 1 year ago

Yes a fallback is a good idea, will add this after https://github.com/matterbridge/matterclient/pull/1 merges

42wim commented 1 year ago

Can you rebase on master? vendor has been updated

hloeung commented 1 year ago

Sure, working on that now.

Apologies for the mess with the various PRs. Will be more careful and neater next time.

hloeung commented 1 year ago

Ok, done. Also pushed up a drive-by fix from https://github.com/42wim/matterircd/pull/491/

42wim commented 1 year ago

Apologies for the mess with the various PRs. Will be more careful and neater next time.

No apologies needed though :) LGTM

hloeung commented 1 year ago

Thank you!