43081j / eslint-plugin-lit

lit-html support for ESLint
116 stars 21 forks source link

bugfix: support tags with empty attributes #120

Closed 43081j closed 2 years ago

43081j commented 2 years ago

parse5 can actually return undefined for attribute locations, so we need to account for that in our location resolution.

once i track down where/why parse5 produces this situation, ill update the parse5 types over on DT too (if its not a parse5 bug).

@stramel an easy one to review here :D if you wouldn't mind

43081j commented 2 years ago

have opened DefinitelyTyped/DefinitelyTyped#56601 to update the parse5 types too.

the tokenizer contains a bug over in parse5 IMO but its looking a little inactive so its probably easier to fix up the types.