search

43081j / eslint-plugin-lit

lit-html support for ESLint
116 stars 21 forks source link

feat: depend on eslint-plugin-wc #143

Closed 43081j closed 1 year ago

43081j commented 1 year ago

Not everyone is aware it exists and really they should be used together, so we may as well just depend on it.

Fixes #85

43081j commented 1 year ago

this is looking less and less possible the more i look at it.

apparently eslint resolves plugins from the cwd which means we'd have to require the consumer to install both as peers anyway to be safe. if we tried to rely on the dependency here, it could be nested and will fail to resolve at lint time.

kinda sucks, guess i might throw this away after all

thoughts @stramel?

stramel commented 1 year ago

I think using the shared config that extends the recommended WC plugin config is the right route. Just need to inform the consumers they need to also install WC plugin as well. Eslint documents that under their shared config section.

43081j commented 1 year ago

im gonna abandon this until eslint flat configs are more of a thing (less experimental), then we can have a much simpler hierarchy (since it allows chaining plugins like this).