43081j / eslint-plugin-lit

lit-html support for ESLint
116 stars 21 forks source link

Account for nullish attribute locations in value-after-constraints #151

Closed 43081j closed 1 year ago

43081j commented 1 year ago

https://github.com/43081j/eslint-plugin-lit/blob/b0d4d6cf26c3b15a83da143c10630131a7e121ee/src/rules/value-after-constraints.ts#L59-L60

somehow this can end up nullish in some situations. not entirely sure why or how but the other rules seem to check for this (even though the type definitions say it shouldn't be possible).

so we should probably just do the same check in this rule