search

43081j / eslint-plugin-lit

lit-html support for ESLint
120 stars 22 forks source link

feat: no native attributes #160

Closed thepassle closed 1 year ago

thepassle commented 1 year ago

@43081j Gonna have to ask you to help satisfy typescript on this one 🙃🫠

thepassle commented 1 year ago

How do you handle version bump/changelog stuff in this repo?

thepassle commented 1 year ago

Thanks for the quick review @43081j , I'll finish this PR up tomorrow :)

thepassle commented 1 year ago

So the getPropertyMap util works, but that only works for static get properties, no for static properties, so that kind of lands me in the same boat as before 😅

Added support for static class fields to the getPropertyMap function

thepassle commented 1 year ago

@43081j ok, should be good now, PTAL 🙂

thepassle commented 1 year ago

Alright, fixed the last review comments, except the trailing comma which I literally cant seem to get rid of 😂 Not really sure what to do about it

https://user-images.githubusercontent.com/17054057/211656306-4b40d35a-c804-4765-9d19-fc981db54156.mov

img

43081j commented 1 year ago

i can probably do the comma when i sort the release out, no worries

left one more comment (sorry) but other than that, seems good

thepassle commented 1 year ago

@43081j updated the tests to use messageId and data, also managed to get rid of the comma lol

When do you think you'll be able to merge/release this? I was hoping to do some maintenance on our eslint configs and stuff today, was hoping to take this along :)

43081j commented 1 year ago

have published 1.8.0

thepassle commented 1 year ago

@43081j Thank you!