rule: require-listener-teardown

43081j commented 3 years ago

This requires that listeners added in connectedCallback are removed in disconnectedCallback.

Some shortcomings where we should improve in future:

It will only detect those attached directly to this for now
It will not yet determine that the correct reference was passed to both cases (i.e. addEventListener('x', foo) is considered cleaned up if we see removeEventListener('x', bar))
It will check all classes without considering base class (should be ok since nobody else uses a connectedCallback usually)

stramel commented 3 years ago

Wouldn't this be a better fit in the WC plugin?

43081j commented 3 years ago

You sir have an excellent point! 😂

I will work on moving it over 👍

43081j commented 3 years ago

Closing this, replaced by 43081j/eslint-plugin-wc#50

43081j / eslint-plugin-lit