Closed 43081j closed 2 years ago
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
lib/locationCorrection.js | 4 | 89.42% | ||
<!-- | Total: | 4 | --> |
Totals | |
---|---|
Change from base Build 1553599349: | -1.3% |
Covered Lines: | 591 |
Relevant Lines: | 599 |
I just tried it!
It seems to solve the problem from before, but a new one arises. See the multiline main
:
@abdonrd thanks for giving it ago, i've published a new @next
, could you try it out?
this was caused by the fact postcss stores the entire selector in a selector
property, containing the whitespace too. so i had to mutate that when stringifying (and have opened postcss/postcss#1691).
Thanks @43081j! Now it works well in the IBM/pwa-lit-template
! 👏🏻
But trying in another project (with the same config) I see more changes:
Also leaving an entire file empty:
😞 its the same problem in a different place.
i think i need to solve it globally somehow.
basically, various AST nodes have string values in them (e.g. rule.selector
, decl.value
, etc). they contain the surrounding whitespace, rather than using the before/after strings we correct.
in this case, the declaration's value needs correcting just the same way we corrected the rule's selector.
the empty file thing is another issue but im sure that'll be an easy fix.
thanks so much for testing, ill see if i can sort them tonight
just an update...
by some miracle i think i may have fixed it for all node types. tomorrow i'll add more tests to confirm this
there's a lot of places indentation can exist so i just need to make sure we have tests for enough of them
edit: i've published a new @next
for you to try out @abdonrd
Thanks @43081j!
Now just this auto fix:
But I don't know if it is a postcss-lit
thing or it's because Stylelint v14.
Well, and still happens that component files are empty.
@abdonrd the first one is stylelint 14.x, they introduced a new recommended rule which migrates all rgb values to space-separated. rgba(r, g, b, a)
becomes rgb(r g b / a)
we had the same huge change in our repos :D was a surprise to me too
i'll try fix the empty file thing tonight
@abdonrd i've fixed the empty file problem now. published a new @next
Yay! It works now, thanks @43081j ! 👏
awesome, ill get it published soon as i can.
thanks so much for testing
Fixes #18
cc @abdonrd
I've published
postcss-lit@next
if you want to try it