444B / streamlit-analytics2

👀 Track & visualize user interactions with your streamlit app
MIT License
22 stars 2 forks source link

[BUG] #97

Closed mcwongmc closed 3 months ago

mcwongmc commented 3 months ago

Describe the bug A clear and concise description of what the bug is.

Expected behavior A clear and concise description of what you expected to happen.

To Reproduce Steps to reproduce the behavior:

  1. Go to '/?analytics=on' path > Danger Zone
  2. Click on 'I'm absolutely sure that I want to reset the results'
  3. See error

Software Versions Please fill in the relevant field:

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

444B commented 3 months ago

@mcwongmc Thank you for raising this! This is a really high quality bug and I can confirm that this is unexpected behavior in the current prod packages. I'll provide an RCA after a fix

I am away from my laptop but within next 24h I will release a new version 0.7.6 with a patch

444B commented 3 months ago

@mcwongmc Thank you again for raising this, this has been resolved in release 0.7.6, available now on pypi

The root cause (as you correctly identified) was the removal on the word "absolutely" on current line 160. This removal was part of a flake8 / Black workflow that removed the word as it picked it up as redundant. Thanks for identifying this!