444Ro666 / MapleEzorsia-v2

v83 Standalone HD dll client/localhost
GNU Affero General Public License v3.0
85 stars 42 forks source link

NPC dialog has new line characters showing as text #11

Closed MatthewHinds closed 1 year ago

MatthewHinds commented 1 year ago

Describe the bug When talking to a NPC, on occasion you will see a \n

\n **To Reproduce** Steps to reproduce the behavior: 1. Talk to any NPC **Expected behavior** No \n appears
444Ro666 commented 1 year ago

hey, thanks for taking the time to report this

unfortunately i cannot reproduce this in my game. could you provide more information such as which npcs you talked to?

thanks you!

MatthewHinds commented 1 year ago

It occurs with every NPC that has lists, so for example Dalair. image

MatthewHinds commented 1 year ago

I resolved it via using a different .exe. It's definitely the hedis client that's causing it. So nothing wrong with the work you've done!

444Ro666 commented 1 year ago

it's odd, i never had this problem with hendi's client before, actually it's the first time i seen anything like this

444Ro666 commented 1 year ago

are you using any other modifications by chance? it could be a bad hook to list function

MatthewHinds commented 1 year ago

I'm not sure where I got the localhost from but it seems to fix that problem. However it does struggle to load your .DLL. I'll probably look into modifying hendis client to resolve the \n issue.

Are you using hendi's client?

444Ro666 commented 1 year ago

yea using hendis and dont have the problem

444Ro666 commented 1 year ago

if you want more help you could join the maple dev discord. i've never seen the N thing happen before but maybe someone there has dealt with it before and could give you more information

leevccc commented 1 year ago

same problem after i use STREDIT.exe to edit 4g exe

444Ro666 commented 12 months ago

dont use stredit for direct edits, ive heard other ppl having issues with that too

just use the stringpool hook in my release and change whatever your want or even replace teh whole thing (there is a version of stringpool hook that does this)

leevccc commented 10 months ago

thanks for your advice.

can you help me? i want to know how to change some text with stringpool. for example, i want to change the text "You have gained mesos (+%d)" to "mesos (+%d)".

i tried to use stredit to search this text, i get a address which the stredit support. and i use your code Memory::WriteString, but it not work. i think the address is error. i have no idea about it...