search

45678 / miniLockLib

Do miniLock encryption operations on a web page of your own.
https://45678.github.io/miniLockLib/
The Unlicense
11 stars 2 forks source link

Update README.md, fix test bug, update depends, replace broken Pow!, no curl to get libs #15

Closed grempe closed 8 years ago

grempe commented 9 years ago

Fix a few issues I ran across when testing this locally. POW server is no longer supported for current versions of OS X, replaced with Caddy server. Updated all NPM dependencies. Fixed a bug where sniff-test for FileReader was not working for some node installations, scrypt-async is in NPM now, no need to pull in from head of master branch with curl, regenerated compiled files with latest version of coffescript.

grempe commented 8 years ago

Any chance of this being pulled upstream? I've heard nothing from @45678 on this pull request.

Thx!

grempe commented 8 years ago

ping? @45678

45678 commented 8 years ago

Thank you for working through these changes @grempe. And thank you for pursuing them with me for such an unreasonably long time. It is a very kind gesture. Thank you.

i haven’t been on the computer in a long time and that’s why i haven’t followed up with you. i am sorry that i didn’t notice this earlier because i know that you were left wondering – in limbo – for a long time.

i haven’t looked at the commits in detail yet but i will check them out later today or tomorrow morning. From the outside looking in they look great. Thanks again.

i will follow up with here you tomorrow.

Again, i am sorry about leaving you in limbo for so long. Kind regards.

45678 commented 8 years ago

Thank you for this thoughtful pull request @grempe. The presentation was great – it was very easy for me to read and follow the changes.

i made a few friendly amendments that are summarized in pull request #17.

grempe commented 8 years ago

Thanks for pulling in the changes. Look forward to trying it out.

45678 commented 8 years ago

No problem @grempe. i was expecting more of your commits to show up in the master branch log. i don’t know how to use git and GitHub very well so i probably could have done the merge better to preserve more of your commits and due credit. anyway, sorry about that.

please do let me know if you run into any trouble with the master branch.

grempe commented 8 years ago

As far as I can tell all of my commits made it to master. I was able to cleanly delete my branch (which git would not let me do if there were unmerged changes).

Thanks. Hope these changes help the next guy. If there were a way to contact you out-of-band (twitter, email, whatever) that would have been helpful too :-)

The new web server changes work fine for me. Better than Pow.

Cheers,

Glenn