45Drives / cockpit-file-sharing

A Cockpit plugin to easily manage samba and NFS file sharing.
GNU General Public License v3.0
556 stars 30 forks source link

Unable to change `fruit:model` identifier to `MacPro7,1@ECOLOR=226,226,224` because equals sign. #103

Closed jason-s13r closed 5 months ago

jason-s13r commented 5 months ago

Bug Info

Describe the bug Unable to set fruit: model = MacPro7,1@ECOLOR=226,226,224 due to = sign being a string split token. The command through the RPC becomes malformed: net conf setparm global fruit:model MacPro7,1@ECOLOR 226,226,224 instead of net conf setparm global fruit:model MacPro7,1@ECOLOR=226,226,224

To Reproduce Steps to reproduce the behavior:

  1. With a Samba global config optimised for MacOS
  2. Edit advanced config textarea
  3. Replace the fruit:model = MacSamba with fruit:model = MacPro7,1@ECOLOR=226,226,224
  4. Save.
  5. See error

Expected behavior Should be able to configure Samba with fruit:model = MacPro7,1@ECOLOR=226,226,224.

Screenshots

image

Console Output

Client Side

Desktop (please complete the following information):

Smartphone (please complete the following information): N/A

Server Side