45Drives / cockpit-file-sharing

A Cockpit plugin to easily manage samba and NFS file sharing.
GNU General Public License v3.0
596 stars 32 forks source link

latest release 4.2.5 is tagged with 4.2.6 #115

Closed solaegis closed 3 weeks ago

solaegis commented 4 weeks ago

Bug Info

Describe the bug latest release 4.2.5 is tagged with 4.2.6 breaking the expected file naming standard. This causes issues with tteck/Proxmox cockpit's installation

To Reproduce Steps to reproduce the behavior:

  1. Go to the releases section of this repo
  2. look at the latest release named Cockpit File Sharing 4.2.5
  3. Notice it is tagged with 4.2.6

Expected behavior The files for the latest release match the semantic tag.

Screenshots Screenshot 2024-10-30 at 4 36 49 PM

bkelly16 commented 3 weeks ago

This is now fixed. Thank you for the report.

image

havardthom commented 2 weeks ago

Hello, there is still a disconnect between github release tag 4.2.5 and filename tag 4.2.5-2 which is causing problems in ProxmoxVE helper script ref. https://github.com/community-scripts/ProxmoxVE/issues/157

I don't see the expected behavior in this issue being fulfilled

Expected behavior The files for the latest release match the semantic tag.

Looks like this also applies to your other Cockpit plugins https://github.com/45Drives/cockpit-identities/releases https://github.com/45Drives/cockpit-navigator/releases