search

45Drives / cockpit-file-sharing

A Cockpit plugin to easily manage samba and NFS file sharing.
GNU General Public License v3.0
596 stars 32 forks source link

Hard dependency on package `cockpit-ws` breaks Podman implementation of `cockpit-ws` #62

Open cig0 opened 2 years ago

cig0 commented 2 years ago

Bug Info

Describe the bug

The RPM package for cockpit-file-sharing installs cockpit-ws as a dependency, which conflicts with the Podman-based deployment, as described in https://github.com/cockpit-project/cockpit-container

To Reproduce Steps to reproduce the behavior: (On a Fedora IoT {36,37} terminal)

  1. rpm-ostree install cockpit-file-sharing
  2. podman container runlabel --name cockpit-ws RUN quay.io/cockpit/ws
  3. See error

Note: this error occurs with the cockpit-file-sharing version shipped with both Fedora IoT 36 and 37, as well as with the RPM package available in this repository (see details below)

Server Side

Additional context

The issue described above happens with both cockpit-file-sharing version 2.4.5-2 (from the Fedora IoT 36 and 37 official repositories), and with version 3.2.9-2 available here.

Why does cockpit-file-sharing enforce cockpit-ws as a dependency?

From what I saw from all other Cockpit applications, none of them has cockpit-ws as a hard dependency (I spent a good amount of time trying to understand which application was breaking my ability to run Cockpit with Podman using the official container when I first encounter this issue ;)

Thanks!

vega-d commented 2 years ago

Can confirm that also affects Fedora CoreOS 35 and newer

joshuaboud commented 2 years ago

Hi, we do not maintain the version of cockpit-file-sharing in Fedora, so to get it fixed there please see https://fedoraproject.org/wiki/Changes/cockpit-file-sharing-2-4-1-5. At least for the original File Sharing here, cockpit-ws is not a direct dependency - it just depends on the cockpit package, which in turn probably depends on cockpit-ws. We will look at changing this dependency to just cockpit-bridge, as I believe that's all it strictly requires.

cig0 commented 2 years ago

Hi @joshuaboud, that sounds like a great approach! (And thanks for the link to Fedora's wiki)

cig0 commented 2 years ago

Can confirm that also affects Fedora CoreOS 35 and newer

Cross-linking bug report at RH's Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2143047