The "Downloading Wordpress files" step sometimes fails

46cl / wp-boilerplate

[unstable] A Wordpress boilerplate created by 46cl

MIT License

3 stars 1 forks source link

The "Downloading Wordpress files" step sometimes fails #3

Closed nesk closed 6 years ago

nesk commented 9 years ago

This is a bug specific to the French version, if the locale option is removed in the task, it works.

nesk commented 9 years ago

Until this is finally fixed, fallback to the en_US version if possible.

nesk commented 9 years ago

Reopening this issue since the implemented solution today is just a simple fallback to the en_US version, which is not what we want to keep in the future.

The reason of those Release not found errors is because only the latest release of each branch is kept for the french version (and probably other languages), the old ones are removed from the available downloads. For example, if we want to download the 4.2.2 version, this is no longer possible because a 4.2.4 release is available.

nesk commented 9 years ago

This issue should be handled this way:

The user runs npm run wp-install.
We check if the version in the wp-project.json file is the latest of its branch.
If its not the latest, stop the installation and output a message asking to update to the X.X.X version in the wp-project.json file.

As a bonus, we could also prompt the user to know if he wants the version to be automatically updated and the installation restarted.