search

47degrees / helios

A purely functional JSON library for Kotlin built on Λrrow
https://47degrees.github.io/helios/
Apache License 2.0
169 stars 22 forks source link

is this a dead comment? #130

Open jnorthrup opened 5 years ago

jnorthrup commented 5 years ago

https://github.com/47deg/helios/blob/1a0fee60e3380c016cfe2aebd0fd93e5aa67545d/helios-parser/src/main/kotlin/helios/parser/Parser.kt#L379

jnorthrup commented 5 years ago

I'm taking a look at Arrow-kt and one of my goto's is to find a json parser done in such and such style.

as i try to sift the Arrow from the kotlin, i notice the comment looks a touch out of sync.. i am curious what prompted the refactoring. any performance numbers to share of when vs if pros/cons ? it certainly would be more readable as when{}

raulraja commented 5 years ago

Last time we checked it was faster due to the optimization to a table switch but feel free to add a benchmark over an alternative implementation and we will use whichever is fastest, thanks.