search

47degrees / helios

A purely functional JSON library for Kotlin built on Λrrow
https://47degrees.github.io/helios/
Apache License 2.0
169 stars 22 forks source link

Sidebar menu nested options support #97

Closed AdrianRaFo closed 5 years ago

AdrianRaFo commented 5 years ago

I tried to this on the sidebar.yml:

  - title: Integrations

    nested_options:

      - title: Retrofit
        url: /docs/integrations/retrofit/

but it didn't work. I looked into the Arrow repo and that should be fine. Any clue @calvellido?

calvellido commented 5 years ago

I was quickly going to tell you that the name was wrong ~siderbar.yml~ -> sidebar.yml, but it is correct in the source code, so let me have a look later in the day and I'll let you know.

calvellido commented 5 years ago

Ha! So after having a look at the reason for nested options not working, is simply that they are not implemented :sweat_smile:

I'll add this to our workflow? How urgent would you say this is at the moment?

AdrianRaFo commented 5 years ago

The release is planned to the end of the month and I would like to have the docs properly for that but as we don't have other integrations at the moment it's not so urgent

AdrianRaFo commented 5 years ago

Helios 0.2.0 release has been done, could this be completed before the public announcement?

calvellido commented 5 years ago

I had it partially done, but not submitted, so here you go:

https://github.com/47deg/helios/pull/108