fix(serializer): Allow serializers to operate on derived `UrlSearchParams` classes

47ng / nuqs

Type-safe search params state manager for React frameworks - Like useState, but stored in the URL query string.

https://nuqs.47ng.com

MIT License

4.86k stars 104 forks source link

fix(serializer): Allow serializers to operate on derived `UrlSearchParams` classes #647

Closed neefrehman closed 1 month ago

neefrehman commented 1 month ago

Follow-up to https://github.com/47ng/nuqs/discussions/646, that allows us to use the response from Next's useSearchParams, for example, as the base argument to a serializer. To do this we create a copy of UrlSearchParams in this code branch.

vercel[bot] commented 1 month ago

@neefrehman is attempting to deploy a commit to the 47ng Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nuqs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 25, 2024 1:52pm

neefrehman commented 1 month ago

@franky47 thanks for the review! I've just implemented the change and test

franky47 commented 1 month ago

Sorry for the close/reopen, my CI workflow wasn't picking subsequent commits from external contributors (should be fixed in #649).