47ng / nuqs

Type-safe search params state manager for React frameworks - Like useState, but stored in the URL query string.
https://nuqs.47ng.com
MIT License
4.86k stars 104 forks source link

Add e2e test environments for other adapters #728

Closed franky47 closed 2 weeks ago

franky47 commented 3 weeks ago

Currently only Next.js is end-to-end tested. In order to ensure the same high standards of quality for other adapters, they should get the same treatment.

There may be a lot of overlap for testing the basic functionality common to each framework, and having to maintain those test pages & fixtures might become painful. Suggestions welcome!

CI Layout

There would be many levels of CI that need to be decoupled to make it all efficient (ie: running jobs in parallel).

  1. Building & unit-testing the library, before anything else. No need to run e2e if this breaks for some reason.
  2. Fan out by framework a. Next.js (all supported versions, with variants) b. Remix (do we need variants?) c. React Router d. React SPA

We can probably remove the ISR invalidation method once we move the docs to Next 15 and "use cache". What's the cache cascade going to look like if the top-level page is static but contains cacheLife / cacheTag elements?

github-actions[bot] commented 1 week ago

:tada: This issue has been resolved in version 2.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: