search

480Oswego2013 / CSC-HCI-480-2013-repo

8 stars 8 forks source link

Licenses on Container Generated Files #18

Closed nonelement closed 11 years ago

nonelement commented 11 years ago

When building the project, licenses are not present on (presumably)generated files, and cause builds to fail unless inserted manually.

(/Web Pages/WEB-INF/glassfish-web.xml, for example, for my environment.)

kevinwinahradsky commented 11 years ago

If this is a generated file it should be generated into the target directory. Do you know what generates it?

As far as I know, most people are using tomcat rather than glassfish so you shouldn't have any problems with that. Also if it contains nothing specific to your environment, like directory paths, then you can probably just commit it for other people who want to use glassfish.

nonelement commented 11 years ago

I assume the file is generated by building and running with Glassfish, since it doesn't appear before then. I'd heard that at least one person was using Glassfish, so I decided to use that. Nothing more than a whim, really, and I'm not sure differences between containers are detrimental at this point.

There isn't anything specific to my environment in the file beyond a specific Glassfish version number in the doctype definition. If this can be ignored, I'll commit it.

kevinwinahradsky commented 11 years ago

Yeah you might as well commit it.