search

486c / rosu-memory

Lightweight, cross-platform memory reader for osu! but in rust
24 stars 7 forks source link

Add accuracy and grade #28

Closed uzervlad closed 11 months ago

uzervlad commented 11 months ago

I assume calculating accuracy should be faster than reading from memory

MaxOhn commented 11 months ago

One downside of calculating things manually is that it likely increases the final binary size a little. Can't say by how much but it should maybe be checked and factored into the decision whether this should be merged.

Another big factor for the decision is of course the performance difference so that could be benchmarked.

486c commented 11 months ago

Calculating acc & grade by ourself gonna be faster than any syscall to OS, especially when we talking about linux. @uzervlad could you rebase/merge newer changes from master + add trace spans, if you don't mind. if not i'm gonna do it myself :)