Use gradual performance calculations for current pp

486c / rosu-memory

Lightweight, cross-platform memory reader for osu! but in rust

24 stars 7 forks source link

Use gradual performance calculations for current pp #30

Closed Chiffario closed 10 months ago

Chiffario commented 11 months ago

Initial pass on this, closes #22

Adds usage of GradualPerformanceAttributes for current_pp. Requires some dirty hacks with passing the current beatmap, but fixing that would require refactoring the way values are generally stored OR the way Values is being referenced

MaxOhn commented 11 months ago

Having to extend the lifetime looks sad but necessary 😭 I'll try to overhaul the gradual calculation API soon:tm: to make it more ergonomic.

Chiffario commented 11 months ago

Fixed an off-by-one error that was caused by a slight logic issue on my side, should be good to go