search

486c / rosu-memory

Lightweight, cross-platform memory reader for osu! but in rust
21 stars 7 forks source link

calculates wrong star rating for converted maps #52

Closed Inconn closed 6 months ago

Inconn commented 6 months ago

afaik, gosu-pp supports converted beatmaps, however when i put on a converted beatmap, i notice that the calculated star rating is incorrect. i'm assuming the pp value is also wrong, but i haven't checked.

Inconn commented 6 months ago

seems you might need to use this function https://docs.rs/rosu-pp/latest/rosu_pp/beatmap/struct.Beatmap.html#method.convert_mode whenever it's a converted map

Inconn commented 6 months ago

i looked thru code, i guess the part that's supposed to be converting it isn't working?

Inconn commented 6 months ago

for the record, the pull request did fix it, but it wasn't optimal. i think the beatmap is getting replaced with the unconverted one for some reason? or not getting converted in the first place?

Inconn commented 6 months ago

I think that it's not recalculating if you change the menu-mode without changing the beatmap