search

486c / rosu-memory

Lightweight, cross-platform memory reader for osu! but in rust
21 stars 7 forks source link

Fix converted map sr #53

Closed Inconn closed 6 months ago

Inconn commented 6 months ago

Fixes #52

I think that the beatmap.convert_mode(mode) function does clone the beatmap variable when it's used, but i don't know what we can do about that. i'm also not sure if that'd actually be an issue. i just threw this together in a few minutes.

I noticed that the star values are still slightly incorrect, but I think this is a rosu-pp issue, not a rosu-memory issue.

Inconn commented 6 months ago

also i dunno if where i put the conversion is ideal, i just put it where i saw the beatmap was getting processed

Inconn commented 6 months ago

nvm i looked thru code, i saw other part, i guess it's not working for some reason?