search

486c / rosu-memory

Lightweight, cross-platform memory reader for osu! but in rust
24 stars 7 forks source link

"data.fc_pp" doesn't show actual "if fc" pp #64

Closed FlySlime closed 8 months ago

FlySlime commented 8 months ago

I'm assuming that the purpose of data.fc_pp is to display the pp value for an fc if you didn't sliderbreak/miss. However this doesn't seem to be the case. It seems like it (almost) displays the value if you got an fc INCLUDING the misses, which is obviously not possible. I'll upload pictures showcasing the problem and the replay.

The value displayed on the key overlay: image

The pp for "full combo" with the misses: image

The actual pp for full combo: image

486c commented 8 months ago

fixed in bde582c2ecc1393885e2ffa46fee59f25e335518