Open golota60 opened 1 year ago
Damn man this awesome.
i've taken a better glance at build differences - all seem to be related to code-splitting, here they are(left is old right is new)
package.json
slight differences(non-issue imo)
typeUtils.ts
to files themselves, instead of a one big file)
server.tsx
missing(this just seems random, think it happened cause stuff wasn't explicitly exported - fixed that in newest commit).So yeah, i think merging this probably won't introduce anything wrong, but since it's a whole switch from JS->TS i expect that some slight issues might come up i've used meld to compare the changes.
Overall I'd say this is ready to be merged(like I said, I expect issues to be small to nonexistent with this), although I'd understand if we want to turn this into a feature branch or something. I'd say we should face it head on and merge this and then deal with any issues while releasing :smile: but that's just me
above and beyonce
things done: