search

4Catalyzer / found

Extensible route-based routing for React applications
https://4catalyzer.github.io/found/
MIT License
794 stars 55 forks source link

Wrong className in Link component with activeClassName #1044

Closed atfera closed 1 year ago

atfera commented 1 year ago

https://github.com/4Catalyzer/found/blob/master/src/Link.tsx#L89

if (activeClassName) {
        // eslint-disable-next-line @typescript-eslint/no-unused-vars
        props.className = props.className
          ? `${props} ${activeClassName}`
          : activeClassName;
      }

at line 89, It should be ${props.className} not ${props}.

golota60 commented 1 year ago

Hey, thanks, good catch - this must've slipped through the TS rewrite