search

4Catalyzer / found

Extensible route-based routing for React applications
https://4catalyzer.github.io/found/
MIT License
794 stars 55 forks source link

fix: pass className in Link #1045

Closed golota60 closed 1 year ago

golota60 commented 1 year ago

Fixes: #1044

golota60 commented 1 year ago

@jquense As a part of this, I've also inspected the output code of js build of 1.1.2 and the the current master, to ensure more silly stuff like this was not introduced. And it seems this + children not passed(which you fixed) were the only issues(I've also reverted only other behavioral change - foundReducer return value was a little bit different in one case - reverted cause someone might be relying on that). I think we should do a release of this once merged

On the bright side, this reminds me that i think tests need a little bit of a refresher :smile:

sushantdhiman commented 1 year ago

Please release this fix @jquense