4D-Technologies / openidconnect_flutter

Complete Flutter OpenIdConnect Library
75 stars 44 forks source link

Feat/keycloak logout support #15

Closed ghost closed 1 year ago

ghost commented 2 years ago

Hi, First of all, thanks for this awesome package that greatly helps dealing with OpenID Connect and saved me a big amount of work !!!

I have an issue with the package that fails loging the user out with Keycloak ID provider. Thus, I added propose you this PR to fix this :

All these changes are backward compatible.

(By the way, I wonder if there is a bug in your logout code : you use get request instead of a post request + you should probably clear user's identity)

Thanks again for sharing this code. Best regards, Renaud

jhancock4d commented 1 year ago

Hi, sorry I've been away from this project so I didn't even see these (and github didn't notify me for some reason).

Could you update the code? Generally the default is GET for logout but can be POST per the spec too, so the solution needs to read this from the site's documentation for what method to use.

Thanks!

ghost commented 1 year ago

Hi @jhancock4d,

No worries, thanks for this (late) feedback. ;) I just updated the code with solved conflicts (which were located in pubspec.lock files)

ahmednfwela commented 1 year ago

related to https://github.com/4D-Technologies/openidconnect_flutter/issues/39 as well