Define defaultClientSecret as Empty when using a PKCE

4D-Technologies / openidconnect_flutter

Complete Flutter OpenIdConnect Library

75 stars 44 forks source link

Define defaultClientSecret as Empty when using a PKCE #6

Open FDuhen opened 3 years ago

FDuhen commented 3 years ago

Hey ! Thank you for this example project and the associated lib. A quick improvement would be to define the defaultClientSecret value as Empty or Null when requesting a PKCE token. If the value is set to a placeholder, the data client_secret will be added in the authent query and it'll fail.

jhancock4d commented 1 year ago

client_secret isn't filled in in the sample to intentionally require you to put in usable credentials one way or another. Since I don't have a public server that I can just link to without having special specific credentials I can't just put anything in so this was my way if requiring you to update the sample before you test run it so that it worked against your environment.

PRs welcome.