4IceG / luci-app-3ginfo-lite

Graphic visualization of the mPCI-E / M.2 and USB 3G / LTE / LTE-A / 5G modem connection status. (LuCI JS) | OpenWrt >= 21.02
100 stars 39 forks source link

Fix B28/32/38 band show #15

Closed stich86 closed 2 years ago

stich86 commented 2 years ago

Hi @4IceG,

today I was able to test B28, B32 and B38 band on MF289F modem, I missed some code so i've added it, now bands are displayed correctly.

Here are some example for B38 and B32:

IMAGE 2022-08-26 19:24:54

IMAGE 2022-08-26 19:25:14

If you agree please integrate in your branch

thanks :)

4IceG commented 2 years ago

Hi @stich86 :)

*"8") MODE="${MODE/LTE/LTE_A} / "$(band 8 "");; Did you test it well? for different variants? because it looks strange to me that line (I have not seen the command, so maybe the syntax looks like that). Very very very strange that only band 8 requires a code change.

A larger list of bands was supposed to be added in the next update, but I already have to add new bands to the list, so I will add that later as well.

Okay I'll add this as something will be corrected in the next update.

stich86 commented 2 years ago

Hi @stich86 :)

*"8") MODE="${MODE/LTE/LTE_A} / "$(band 8 "");;

Did you test it well? for different variants? because it looks strange to me that line (I have not seen the command, so maybe the syntax looks like that). Very very very strange that only band 8 requires a code change.

A larger list of bands was supposed to be added in the next update, but I already have to add new bands to the list, so I will add that later as well.

Okay I'll add this as something will be corrected in the next update.

The case with *"8") evaluates band "38" as 8 instead of it's number. So I've added "^" to be sure the number starts with 8.

I think the problem can happens also with band 2 (not used there) with 20/28.