4JX / L5P-Keyboard-RGB

Cross platform software to control the RGB/lighting of the 4 zone keyboard included in the 2020, 2021, 2022 and 2023 lineup of the Lenovo Legion laptops. Works on Windows and Linux.
GNU General Public License v3.0
324 stars 41 forks source link

Unable to Save an effect #169

Open AtlasXT9 opened 2 months ago

AtlasXT9 commented 2 months ago

like the profiles that show after you save them, i want to save effects that i create to use on the fly, but unable to do so, only able to run them from the effects tab. Screenshot 2024-08-26 181506 also unable to save effects altogether. the readme says that i can use effects from GUI or double click on the file to do so, but even after i tell to open with legion RGB, nothing works. please help out, i really want to make some cool custom effects like Asus has on their laptops @quicquid @jValdron @pavelsevcik @mariobalanica @rslarson #

4JX commented 2 months ago

Do not ping every contributor, that just annoys unrelated people that have added code at some point.

i want to save effects that i create to use on the fly, but unable to do so, only able to run them from the effects tab. Screenshot 2024-08-26 181506

also unable to save effects altogether.

There's no effect "saving" functionality because there's also no way to create them within the app. You're supposed to edit the text yourself and load the files.

from GUI or double click on the file to do so

You can load them through the app, but not via the "open with" dialog. That I might be able to improve.

AtlasXT9 commented 2 months ago

@4JX i have another question, in the Christmas effect it starts with a very smooth wave from side to side in a very smooth manner. i want to do that in while writing a json file but unable to do that, please allow to set a slow smooth wave (single color) and in the breath

https://github.com/user-attachments/assets/3bdfd45c-36b7-4fb5-b35c-cbac178978d6

i have attached a video, it looks a lot smoother in real. i want to do something like that, please help out brother!! more precisely, i want to do a single color wave! i also request for more increments in wave and smooth wave speed. i also request - breathing effect, how about breath into different color sets? that would be very cool!

4JX commented 2 months ago

You can do that with the swipe effect: image

Or for more complex movement/color shifting custom effects can do the job:

{
    "effect_steps": [
        {"rgb_array": [255, 255, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], "step_type": "Transition", "brightness": 2, "steps": 100, "delay_between_steps": 5, "sleep": 0},
        {"rgb_array": [0, 0, 0, 255, 255, 0, 0, 0, 0, 0, 0, 0], "step_type": "Transition", "brightness": 2, "steps": 100, "delay_between_steps": 5, "sleep": 0},
        {"rgb_array": [0, 0, 0, 0, 0, 0, 255, 255, 0, 0, 0, 0], "step_type": "Transition", "brightness": 2, "steps": 100, "delay_between_steps": 5, "sleep": 0},
        {"rgb_array": [0, 0, 0, 0, 0, 0, 0, 0, 0, 255, 255, 0], "step_type": "Transition", "brightness": 2, "steps": 100, "delay_between_steps": 5, "sleep": 0},
        {"rgb_array": [0, 0, 0, 0, 0, 0, 255, 255, 0, 0, 0, 0], "step_type": "Transition", "brightness": 2, "steps": 100, "delay_between_steps": 5, "sleep": 0},
        {"rgb_array": [0, 0, 0, 255, 255, 0, 0, 0, 0, 0, 0, 0], "step_type": "Transition", "brightness": 2, "steps": 100, "delay_between_steps": 5, "sleep": 0}
    ],
    "should_loop": true
}
AtlasXT9 commented 2 months ago

hey can we loop for some iterations? like i want to loop for 10 iterations and move on to next effect? how to speed up the above effect? reduce steps? also can you please add an option to save and delete effects like we can save and delete profiles, i want to be able to use them on the fly, dont want to keep going into effects and searching for json file again and again pls pls! thanks for the help!!🫡

AtlasXT9 commented 2 months ago

hey can we loop for some iterations? like i want to loop for 10 iterations and move on to next effect? how to speed up the above effect? reduce steps? also can you please add an option to save and delete effects like we can save and delete profiles, i want to be able to use them on the fly, dont want to keep going into effects and searching for json file again and again pls pls! thanks for the help!!🫡

4JX commented 2 months ago

hey can we loop for some iterations? like i want to loop for 10 iterations and move on to next effect?

You'd have to copy+paste that specific section you want to repeat for as many loops as you want.

how to speed up the above effect? reduce steps?

You can reduce the step count, meaning bigger jumps, or the time between steps, leading to smaller changes per step

also can you please add an option to save and delete effects

Yes, that's something I'll see about implementing